RustのOSSを探索（してコントリビュート）した話

├── checks
│   ├── duplicated_key.rs
│   ├── ending_blank_line.rs
│   ├── extra_blank_line.rs
│   ├── incorrect_delimiter.rs
│   ├── key_without_value.rs
│   ├── leading_character.rs
│   ├── lowercase_key.rs
│   ├── quote_character.rs
│   ├── space_character.rs
│   ├── trailing_whitespace.rs
│   └── unordered_key.rs
├── checks.rs
├── common.rs
├── fixes
│   ├── extract_blank_line.rs
│   ├── key_without_value.rs
│   ├── lowercase_key.rs
│   ├── space_character.rs
│   └── trailing_whitespace.rs
├── fixes.rs
├── fs_utils.rs
├── lib.rs
└── main.rs

trait Fix {
    fn name(&self) -> &str;

    fn fix_warnings(
        &self,
        warnings: Vec<&mut Warning>,
        lines: &mut Vec<LineEntry>,
    ) -> Option<usize> {
        let mut count: usize = 0;
        for warning in warnings {
            let line = lines.get_mut(warning.line_number() - 1)?;
            if self.fix_line(line).is_some() {
                warning.mark_as_fixed();
                count += 1;
            }
        }

        Some(count)
    }

    fn fix_line(&self, _line: &mut LineEntry) -> Option<()> {
        None
    }
}

fn fixlist() -> Vec<Box<dyn Fix>> {
    vec![
        // At first we run the fixers that handle a single line entry (they use default
        // implementation of the fix_warnings() function)
        Box::new(key_without_value::KeyWithoutValueFixer::default()),
        Box::new(lowercase_key::LowercaseKeyFixer::default()),
        Box::new(space_character::SpaceCharacterFixer::default()),
        Box::new(trailing_whitespace::TrailingWhitespaceFixer::default()),
        // Then we should run the fixers that handle the line entry collection at whole.
        // And at the end we should run the fixer for ExtraBlankLine check (because the previous
        // fixers can create additional extra blank lines).
        Box::new(extract_blank_line::ExtraBlankLineFixer::default()),
    ]
}

// tests/fixes/extract_blank_line.rs
#[test]
fn extract_blank_line() {
    let testdir = TestDir::new();
    let testfile = testdir.create_testfile(".env", "ABC=DEF\n\n\nFOO=BAR\n");
    let expected_output = String::from(
        "Fixed warnings:\n\
        .env:3 ExtraBlankLine: Extra blank line detected\n",
    );
    testdir.test_command_fix_success(expected_output);

    assert_eq!(testfile.contents().as_str(), "ABC=DEF\n\nFOO=BAR\n");

    testdir.close();
}

    /// Run the default CLI binary, with "-f", in this TestDir and check it succeeds.
    pub fn test_command_fix_success(&self, expected_output: String) {
        let mut cmd = Self::init_cmd();
        let canonical_current_dir = canonicalize(&self.current_dir).expect("canonical current dir");
        cmd.current_dir(&canonical_current_dir)
            .args(&["-f"])
            .assert()
            .success()
            .stdout(expected_output);
    }

// check and remove all blank lines.
let mut is_preview_line_blank = false;
lines.clone().iter().enumerate().for_each(|(i, line)| {
    let is_empty = line.is_empty();
    if is_empty && is_preview_line_blank {
        lines.remove(i - count);
        count += 1;
    }

    is_preview_line_blank = is_empty;
});

// check and remove all blank lines.
lines.dedup_by(|a, b| a.is_empty() && b.is_empty());